New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create only one SSH session per GitOperation #1012
Conversation
I'm still surprised this works as per hierynomus/sshj#584 (comment), so please try to break it. |
Oh? Hold off the merge then I'll try some of my broken-ish servers. |
Thanks! On a slightly different note: While testing, I discovered that we currently always create a sync commit, even if it's empty (see android-password-store/pass-test@cd23dab). This is not a big problem, but unnecessarily complicates the Git history. Is this something that would be easy to change? |
Yeah I'll take a look, shouldn't be impossible. |
馃摙 Type of change
馃摐 Description
We should only create a single SSH session per GitOperation to reduce overhead and prevent repeated password prompts without bandaid solution and I finally figured out how to do it.
Along the way, a subtle bug is fixed that can lead to Git operations continuing after an error has been encountered.
馃挕 Motivation and Context
Would greatly improve the usability of #995 with security tokens and simplifies the code considerably.
馃挌 How did you test it?
I synced and cancelled password prompts and everything worked as expected.
馃摑 Checklist
馃敭 Next steps
馃摳 Screenshots / GIFs