Sort by recently used #1031
Merged
Sort by recently used #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Aug 19, 2020
msfjarvis
reviewed
Aug 19, 2020
|
would it be better to save the file path or a hash? |
|
I think i included all your reviews and manage the case of renaming category/password |
fmeum
reviewed
Aug 19, 2020
app/src/main/java/com/zeapo/pwdstore/crypto/PasswordCreationActivity.kt
Outdated
Show resolved
Hide resolved
| val timeP1 = recentHistory.getString(p1.file.absolutePath) | ||
| val timeP2 = recentHistory.getString(p2.file.absolutePath) | ||
| when { | ||
| timeP1 != null && timeP2 != null -> timeP2.compareTo(timeP1) |
There was a problem hiding this comment.
This could be simplified using compareBy and nullsLast, but I could also add that later.
There was a problem hiding this comment.
I'll leave it to you, I have no idea how to use those...
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
approved these changes
Aug 20, 2020
Dioxo
commented
Aug 20, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
I added a new
PasswordSortOrderfor recently used passwords, saving the time when the password was used and comparing with others.馃挕 Motivation and Context
#535
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps
馃摳 Screenshots / GIFs