Migrate design system to Material You #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
added
A-UI-UX
|
Damn, the app looks lit af 馃敟 |
Skrilltrax
reviewed
Nov 3, 2021
Skrilltrax
approved these changes
Nov 3, 2021
This reverts commit 2a9d217.
|
ModernAndroidPreferences has been updated to allow clients to provide their own dialog builder factory, once the next release happens we'll have consistent M3 dialogs everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
Migrates APS to use Material You themes and components wherever possible, cleaning up hard-coded colors and themes as well as performing various other cleanups in the process.
We also enable support for dynamic colors on API 31 so Android 12 users can have a consistent UI with the rest of their system and Google apps.
馃挕 Motivation and Context
Material You is the next iteration of Material Design and the library ecosystem around it has reached sufficient maturity for us to be able to migrate to it.
馃挌 How did you test it?
Visual verification of all screens.
馃摑 Checklist
./gradlew spotlessApply馃敭 Next steps
Dialogs used by our preference library still rely on AppCompat and hence do not respect the new theming/styling changes, being tracked here.馃摳 Screenshots / GIFs
Screenshots (light + dark Material You dynamic colors)
Screenshots (new color palette, no dynamic colors)