-
-
Notifications
You must be signed in to change notification settings - Fork 277
Add Keystore backend for SSH public key authentication #1070
Conversation
We're definitely going to have to document this in the wiki when it ships. I'll review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks pretty solid, really great work here! I'll take it for a spin.
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works in my testing, if the changelog entries look good then you can go ahead and merge it.
Thanks, they do a pretty good job at communicating the changes. |
* develop: Add Keystore backend for SSH public key authentication (#1070) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Is this change compatible for users upgrading from v1.11.3 w/ SSH key authentication? I privately contacted the reporter for #1067 to see if #1066 solved his problem but after upgrading to the latest snapshot git operations prompted that their SSH key is missing. Generating a new key fixed the issue, but we'll either need to add a migration or notify users that they'll need new SSH keys and why. |
Sorry about that, I forgot to add the (trivial) migration. Will send a PR in a minute. |
📢 Type of change
📜 Description
Implement an SSH auth method backed by an Android Keystore key and make SshKeyGenFragment generate such a key.
In detail, this means the following:
The new
SshKey
objects deals with everything SSH pubkey related, e.g. also with key import. I also modernized the SSH key gen and key view activities.Also, Small changes were made to BiometricAuthenticator to fix one of two memory leaks.
💡 Motivation and Context
Supersedes #807.
💚 How did you test it?
Tried to authenticate with all key types. Please test this extensively.
📝 Checklist
🔮 Next steps
CHANGELOG entry
📸 Screenshots / GIFs